Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatable doc updates #281

Merged
merged 2 commits into from Jun 23, 2023
Merged

Updatable doc updates #281

merged 2 commits into from Jun 23, 2023

Conversation

julianrubisch
Copy link
Contributor

Documentation

Description

Added documentation about failing updates, and output the offending element in the browser console.

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for cableready ready!

Name Link
🔨 Latest commit 007e1d6
🔍 Latest deploy log https://app.netlify.com/sites/cableready/deploys/6492f8fbd95cad00084a7014
😎 Deploy Preview https://deploy-preview-281--cableready.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -139,7 +139,8 @@

if (fragments.length <= blockIndex) {
console.warn(
`Update aborted due to insufficient number of elements. The offending url is ${this.url}.`
`Update aborted due to insufficient number of elements. The offending url is ${this.url}, the offending element is:`,

Check failure

Code scanning / CodeQL

Use of externally-controlled format string High

Format string depends on a
user-provided value
.
@julianrubisch julianrubisch merged commit ecd3b9c into main Jun 23, 2023
19 of 20 checks passed
@julianrubisch julianrubisch deleted the updatable-doc-updates branch June 23, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants