Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observer gem to gemspec #294

Merged
merged 1 commit into from May 2, 2024
Merged

Add observer gem to gemspec #294

merged 1 commit into from May 2, 2024

Conversation

marcoroth
Copy link
Member

Type of PR

Enhancement

Description

Ruby 3.4 removes the observer gem from the standard gems which is why we have the declare the dependency explicitly now.

From https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/:

Standard library updates

RubyGems and Bundler warn if users do require the following gems without adding them to Gemfile or gemspec. This is because they will become the bundled gems in the future version of Ruby.

Fixes #293

Why should this be added

To provide Ruby 3.4+ support.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

Copy link

netlify bot commented May 2, 2024

Deploy Preview for cableready ready!

Name Link
🔨 Latest commit ad69248
🔍 Latest deploy log https://app.netlify.com/sites/cableready/deploys/6633e379cb92b500084b7030
😎 Deploy Preview https://deploy-preview-294--cableready.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcoroth marcoroth merged commit 9cfa12c into main May 2, 2024
19 checks passed
@marcoroth marcoroth deleted the observer branch May 2, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 3.3 warnings about observer gem being removed from the standard library
1 participant