Retry to resolve an element

[julianrubisch]

Enhancement

Description

Wrapped the dispatchAppearEvent(entry, observer) in a setInterval, which is cleared upon disconnection. Note that there is a bit of a shotgun surgery here, which at the moment I don't know to avoid - but it's only 3 instances.

Also yet TODO is the configuration of the interval time. I suggest specifying this via a custom element attribute, which could be passed in by the helper.

Fixes #75

Why should this be added

Resilience to network conditions etc.

Checklist

• My code follows the style guidelines of this project
• Checks (StandardRB & Prettier-Standard) are passing

[julianrubisch]

@rickychilcott care to weigh in? I think this should do it...

[rickychilcott]

I've got this pulled up and will take a look in the morning.

[julianrubisch]

we could also try exponential backoff like in rails/rails@cc9a9e8

thanks @leastbad for the suggestion!

[rickychilcott]

I'm sorry for failing to review this. It seems like a very reasonable solution and doesn't feel like it too invasive of a solution.

RE: exponential backoff. It's a good point. Perhaps 3 seconds is enough for a small partial, but it could be a massive partial that is really taking longer to generate, and continuing to hammer every X seconds would be counterproductive.

It would significantly complicate the code, but as you link to or perhaps this implementation it might not be too bad.

Is there anything I can do to wrap this up? I now have approval to start implementing SR into my application slowly, and futurism is going to be a big part of performing the perceived performance of the application. This will be quite helpful.

[leastbad]

That's great news, Ricky!

[julianrubisch]

Thank you @rickychilcott ! I will give your link a thorough read. I hope that with exponential backoff we can craft a config-less solution.

Will revisit this later this week.

[rickychilcott]

👏 👏 👏

This looks good!

[julianrubisch]

Cool will cross check tomorrow and merge