Add docs about Postgres SSL certs #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmerrick Is this ready for review, or do you still have changes you want to make? |
|
@erinkcochran87 ready for review now! |
added 2 commits
November 16, 2018 15:06
- Update the copy for the SSL checkbox - Add copy for the certificate box
|
LGTM
…On Fri, Nov 16, 2018 at 3:14 PM Erin Cochran ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In _data/ui/destination-settings-page.yml
<#200 (comment)>:
> @@ -50,6 +52,12 @@ default-copy:
Enter the password associated with the Stitch {{ destination.display_name }} user.
database: &database-copy |
Enter the name of the {{ destination.display_name }} database that you created for Stitch.
+ ssl: &ssl-copy |
+ Check to connect to {{ destination.display_name }} using SSL. **Note**: This is not required to connect Stitch.
+ ssl-certificate: &ssl-certificate-copy |
+ **Optional**: Provide the certificate (typically a CA or server certificate) Stitch should verify the SSL connection against. The connection will succeed only if the server's certificate verifies against the certificate provided here.
+
+ **Note**: Providing a certificate isn't required to use SSL. This is only if Stitch should verify the connection against a specific certificate.
@cmerrick <https://github.com/cmerrick> Ok - I added a brief description
about the cert box here, based on what you wrote originally. I believe this
line is correct, but I'd feel better about the wording if you could verify
its accuracy for me :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#200 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMpUn69hn_jQQ_giqOSVeeG0-cEOjnZks5uvxyngaJpZM4Ybh2E>
.
|
erinkcochran87
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for user-provided SSL certificates for PostgreSQL destinations.