New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating SVG Logos Viewbox and excess html #56

Merged

jamesmadson merged 1 commit into master from feature-svg-viewbox

Dec 17, 2020

Collaborator

jamesmadson commented Dec 8, 2020

Just updating the St. Jude Cloud SVG logos per Clay's request for consistency in the view box for the Child logo.

Could we add the viewBox property to the St. Jude child logo on design.stjude.cloud? Right now, the scaling correctly since the viewbox is not defined
Eyeballing it, this appears to be the best value I can get: viewBox="0 -50 500 400"
To keep the same proportions as the omnibar


          Updating SVG Logos Viewbox and excess html

c5d06b4

jamesmadson added the enhancement label

jamesmadson requested a review from sawiggins

December 8, 2020 17:20

github-actions bot commented Dec 8, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-wave-007c8ea0f-56.eastus2.azurestaticapps.net

sawiggins approved these changes

View reviewed changes

jamesmadson merged commit 067478e into master

jamesmadson deleted the feature-svg-viewbox branch

December 17, 2020 03:25

acchiao pushed a commit that referenced this pull request


          Updating SVG Logos Viewbox and excess html (#56) 067478e

1a0e0b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels