Feature/new omnibar #60
Conversation
Breaking when used in Omnibar, so reverted to OG SVG file. Uploaded an EPS to use for Sketch or Illustrator.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-wave-007c8ea0f-60.eastus2.azurestaticapps.net |
There was a problem hiding this comment.
Nice and yay for SJC accounts!
I don't love the exaggerated spacing in the nav bar as it looks unintentional until you hover and then I get it but don't know that it worth it (it also gets really tall on mobile). The pill shapes inside the rounded white boxes are also too many rounded boxes for me. I'd consider another hover option and bringing in the space between the list elements.
Have we checked the contrast for the research domain text, the tiny gray text, and the light blue external link icons? It all seems really light.
A few ideas offhand. Perhaps, for the research domains, we could fill in the pill shape to 100% and use white text. The text under the support column needs additional emphasis on hover – perhaps an underline or matching the apps column. Or since we have so much space horizontally for the omnibar, maybe the hover is out to one side (though I guess that could get tricky with the app column).
| <span class="logo"></span> | ||
| </a> | ||
| <a class="sjc-title" href="https://stjude.cloud">St. Jude Cloud</a> | ||
| <span class="portal-title"> |
There was a problem hiding this comment.
I'd update "portal" to "app" where we see it going forward to keep our language consistent.
| /> | ||
| <span> | ||
| Genomics Platform | ||
| <div class="app-subtext">Data & Tools</div> |
There was a problem hiding this comment.
If we add the app's subtitles, the one for Genomics Platform should be updated to "Sequencing Data and Analysis" rather than using our carry-over language from before the redesign.
| --> | ||
| <span> | ||
| JM | ||
| <!-- This is the user's initials, but we could add profile images later --> |
There was a problem hiding this comment.
Are we ready to set this up to be populated via accounts rather than hardcoded (even if it is initials)?
|
@sawiggins Thanks for the review, great points. I'll make sure to address them in the official PR. I set up this PR as a Draft, I still have work to finalize and review with Kirby. |
This is a PR to revise the omnibar and add in the proper styles/html for Accounts.