Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test cleanup #770

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Unit test cleanup #770

merged 1 commit into from
Sep 26, 2023

Conversation

eamonnmcmanus
Copy link
Contributor

One test method was missing @Test so it was never run.

One test method used another test class as the base for finding a test resource. While this works in practice with Maven, it is not strictly right.

One test method was missing `@Test` so it was never run.

One test method used another test class as the base for finding a test
resource. While this works in practice with Maven, it is not strictly
right.
@stleary
Copy link
Owner

stleary commented Sep 19, 2023

What problem does this code solve?
Fixed 2 unit tests

Risks
Low

Changes to the API?
N/A

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
N/A

Review status
APPROVED

Starting 3-day comment window

@stleary stleary merged commit 4e8231c into stleary:master Sep 26, 2023
5 checks passed
@stleary stleary changed the title Small test fixes. Unit test cleanup Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants