Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix All Compiler Warnings #807

Closed

Conversation

theKnightsOfRohan
Copy link
Contributor

@theKnightsOfRohan theKnightsOfRohan commented Oct 17, 2023

This pull request addresses the compiler comment warnings that were previously present in the project. The warnings were identified during the gradle build task execution.

I added or changed javadoc comments to:

  • JSONObject.java (getMapType(), constructor, quote())
  • JSONPointer.java (constructor)
  • JSONPointerException.java (both constructors)
  • JSONTokener.java (close())
  • ParserConfiguration.java (both basic constructors)
  • XML.java (TYPE_ATTR)

Please review the changes and let me know if you have any questions or suggestions.

@stleary
Copy link
Owner

stleary commented Oct 17, 2023

@theKnightsOfRohan Thanks for the PR. Please limit your changes to the warnings described in the issue.

@theKnightsOfRohan
Copy link
Contributor Author

@theKnightsOfRohan Thanks for the PR. Please limit your changes to the warnings described in the issue.

Sure! Do you want the rest of the changes in a separate PR, or are they unneeded right now?

@stleary
Copy link
Owner

stleary commented Oct 17, 2023

Thanks, Hacktoberfest results in a lot of file changes in a short timeframe by people who may not be familiar with the project. It's better to limit the changes during this time.

@theKnightsOfRohan theKnightsOfRohan changed the title Fix Compiler Warnings (Issue #800) Fix All Compiler Warnings Oct 17, 2023
@theKnightsOfRohan
Copy link
Contributor Author

Thanks, Hacktoberfest results in a lot of file changes in a short timeframe by people who may not be familiar with the project. It's better to limit the changes during this time.

Done! The short pull request is #808.

@stleary
Copy link
Owner

stleary commented Oct 17, 2023

Closing this PR, fix was made in #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants