-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented custom duplicate key handling (#840) #857
Conversation
- Supports: throw an exception (by default), ignore, overwrite & merge into a JSONArray - With tests, 4/4 passed.
whoa, 2 different errors, working on them |
I can't believe it throws a StackOverFlowError while compiling, should I add a -Xss4M jvm argument to the actions file? |
It appears to be an intermittent error, only seems to affect Java v11, root cause unknown. After a couple of retries it was successful. Also, the build and test using Java v11 is successful on my laptop. No changes needed at this time. However, your code is out of date, please merge from the latest master branch. |
I found the isKeepStrings() method is unused in the JSONParserConfiguration class, should I overwrite the method and throws an UnsupportedOperationException? |
That method is used by JSONML and XML classes, please don't make any changes to it. |
I see, thanks! |
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3-day comment window |
@XIAYM-gh Please merge from the latest master branch, the PR is not up to date. |
Oh, I apologize for the late reply, I was just back from school, and I'm sorry for the inconvenience that I've caused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new JSONParserConfiguration ctor will be removed in a followup commit.
Supports: throw a JSONException (by default),
ignore (not overwritting), overwriteor merge into a JSONArray;also with tests in a separated file
xD, thanks for reviewing