Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved type handling by AdsSymbol #206

Merged
merged 3 commits into from Feb 17, 2021
Merged

Improved type handling by AdsSymbol #206

merged 3 commits into from Feb 17, 2021

Conversation

RobertoRoos
Copy link
Contributor

@RobertoRoos RobertoRoos commented Feb 17, 2021 •
edited

  • Corrected definition of DT
  • Added DATE_AND_TIME types
  • Added case for strings (and other types which might be defined as a list)

Fixes #205

@coveralls
Copy link

Pull Request Test Coverage Report for Build 631

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 94.412%
Totals Coverage Status
Change from base Build 627: 0.05%
Covered Lines: 1115
Relevant Lines: 1181
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Feb 17, 2021 •
edited

Pull Request Test Coverage Report for Build 631

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 94.412%
Totals Coverage Status
Change from base Build 627: 0.05%
Covered Lines: 1115
Relevant Lines: 1181
💛 - Coveralls

stlehmann
stlehmann approved these changes Feb 17, 2021
View reviewed changes
Copy link
Owner

@stlehmann stlehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this solves #189. Nice work 👍

@RobertoRoos
Copy link
Contributor Author

Great, this solves #189. Nice work 👍

Well, solves it -ish, depending on what intended behaviour we have in mind. But it might be best to consider further handling of structs as new features.

@stlehmann
Copy link
Owner

stlehmann commented Feb 17, 2021 •
edited

Well, solves it -ish, depending on what intended behaviour we have in mind. But it might be best to consider further handling of structs as new features.

I agree. Handling structures is a completely different beast which I would like to tackle in the time to come.

@stlehmann stlehmann merged commit 2dfdaef into stlehmann:master Feb 17, 2021
@stlehmann stlehmann mentioned this pull request Feb 17, 2021
Closed
@RobertoRoos RobertoRoos deleted the feature/types branch February 19, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlehmann stlehmann stlehmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct support for DATE, DATE_AND_TIME and DT
3 participants
@RobertoRoos @coveralls @stlehmann