Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] st-util: removed now useless v1/v2 STLink version stuff #934

Merged
merged 3 commits into from Apr 22, 2020

Conversation

grevaillot
Copy link
Collaborator

well, not needed anymore.

@grevaillot
Copy link
Collaborator Author

nb: st-util probe mentions the not so documented probe filter thingie using

 "The STLINKv2 device to use can be specified in the environment\n"  "The STLINK device to use can be specified in the environment\n"
 "variable STLINK_DEVICE on the format <USB_BUS>:<USB_ADDR>.\n"  "variable STLINK_DEVICE on the format <USB_BUS>:<USB_ADDR>.\n"

this should probably be documented somewhere in the documentation or in other tools commandline help.

@Nightwalker-87 Nightwalker-87 self-requested a review April 19, 2020 11:09
@Nightwalker-87 Nightwalker-87 added this to In progress in Release v1.6.1 via automation Apr 19, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.6.1 milestone Apr 19, 2020
Release v1.6.1 automation moved this from In progress to Reviewer approved Apr 19, 2020
@Nightwalker-87
Copy link
Member

nb: st-util probe mentions the not so documented probe filter thingie using

 "The STLINKv2 device to use can be specified in the environment\n"  "The STLINK device to use can be specified in the environment\n"
 "variable STLINK_DEVICE on the format <USB_BUS>:<USB_ADDR>.\n"  "variable STLINK_DEVICE on the format <USB_BUS>:<USB_ADDR>.\n"

this should probably be documented somewhere in the documentation or in other tools commandline help.

I think it should go to /doc/man/st-util.md as well, but as I can see the stuff there seems outdated as well and does not match the output of st-util --help anymore ... 😞

@Nightwalker-87
Copy link
Member

@grevaillot: Could you add the doc part to this PR as well, so that we have it all together? That would be great.

@grevaillot
Copy link
Collaborator Author

I'll have a look

@Nightwalker-87 Nightwalker-87 self-requested a review April 21, 2020 13:43
@grevaillot
Copy link
Collaborator Author

nb: st-util probe mentions the not so documented probe filter thingie using

 "The STLINKv2 device to use can be specified in the environment\n"  "The STLINK device to use can be specified in the environment\n"
 "variable STLINK_DEVICE on the format <USB_BUS>:<USB_ADDR>.\n"  "variable STLINK_DEVICE on the format <USB_BUS>:<USB_ADDR>.\n"

this should probably be documented somewhere in the documentation or in other tools commandline help.

I think it should go to /doc/man/st-util.md as well, but as I can see the stuff there seems outdated as well and does not match the output of st-util --help anymore ...

actually these env variables are used in all tools - these are checked in the probe code .. So, all doc need to be updated :)

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Apr 22, 2020

We also have /doc/man/st-info.md and /doc/man/st-flash.md ;-)
... but I can't find any related stuff in our tutorial where it would fit in well. 😕

@grevaillot
Copy link
Collaborator Author

probe filter might not really be needed in tutorial i think. I updated the doc to remove the version filter and to mention the --serial parameter where STLINK_DEVICE is mentionned tool

@Nightwalker-87 Nightwalker-87 changed the title st-util: remove v1/v2 stlink version stuff, useless st-util: removed now useless v1/v2 STLink version stuff Apr 22, 2020
@Nightwalker-87 Nightwalker-87 merged commit 8de09dc into stlink-org:develop Apr 22, 2020
Release v1.6.1 automation moved this from Reviewer approved to Done Apr 22, 2020
@slyshykO
Copy link
Collaborator

@grevaillot Congrat 🎉

@Nightwalker-87 Nightwalker-87 changed the title st-util: removed now useless v1/v2 STLink version stuff [refactoring] st-util: removed now useless v1/v2 STLink version stuff Apr 22, 2020
@grevaillot grevaillot deleted the to_merge/gdbserver-v1v2 branch April 22, 2020 11:24
@stlink-org stlink-org locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants