Adding missing RCC_CRRCR register #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could most probably apply to other l4 family. Let me know the name of the peripheral/rcc file name if refactoring is needed. |
mathk
force-pushed
the
master
branch
3 times, most recently
from
d60fb1f
to
ca13e86
Compare
|
CRRCR is missing on stm32l4x5 and stm32l4x6 |
adamgreig
requested changes
Jan 16, 2019
burrbull
reviewed
Jan 18, 2019
|
@adamgreig I think this is now ready. Let me know if you need more change. |
This was referenced Feb 3, 2019
adamgreig
approved these changes
Feb 24, 2019
|
Thanks for this fix! Has it been released yet? I'm blocked by the same error as stm32-rs/stm32l4xx-hal#38, which can't be fixed until a new version of this crate is cut with this fix. |
|
@twilco this hasn't been released yet but will be in the next release 0.7.0, which I hope to cut once I finish the other pending reviews sometime in the next week. |
|
Great, thanks @adamgreig! |
|
Hey @adamgreig - any updates on when |
bors bot
added a commit
that referenced
this pull request
May 28, 2019
218: stm32h7x3: flash access and usart/uart confusion r=adamgreig a=richardeoin Fix some subtle errors * stm32h7: fix write-only and read-only registers in FLASH * stm32h7: Fix confusion between USART and UART in RCC RSTR / ENR 219: Add missing crrcr reg for l4x3 series chips r=adamgreig a=MabezDev It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that. Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com> Co-authored-by: Scott Mabin <mabezdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.