-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing crrcr reg for l4x3 series chips #219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgreig
previously approved these changes
May 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! I can release this as a patch release soon to help with the HAL issue.
bors r+
Awesome! |
Build failed |
Ugh I think this is some weird build thing, will investigate.
… |
bors retry |
bors bot
added a commit
that referenced
this pull request
May 28, 2019
218: stm32h7x3: flash access and usart/uart confusion r=adamgreig a=richardeoin Fix some subtle errors * stm32h7: fix write-only and read-only registers in FLASH * stm32h7: Fix confusion between USART and UART in RCC RSTR / ENR 219: Add missing crrcr reg for l4x3 series chips r=adamgreig a=MabezDev It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that. Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com> Co-authored-by: Scott Mabin <mabezdev@gmail.com>
Build failed (retrying...) |
Build failed |
adamgreig
approved these changes
May 30, 2019
bors retry |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that.