Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing crrcr reg for l4x3 series chips #219

Merged
merged 2 commits into from
May 30, 2019

Conversation

MabezDev
Copy link
Member

It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that.

adamgreig
adamgreig previously approved these changes May 27, 2019
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I can release this as a patch release soon to help with the HAL issue.

bors r+

@adamgreig adamgreig added the non-breaking-change PR does not contain breaking change label May 27, 2019
bors bot added a commit that referenced this pull request May 27, 2019
219: Add missing crrcr reg for l4x3 series chips r=adamgreig a=MabezDev

It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that.

Co-authored-by: Scott Mabin <mabezdev@gmail.com>
@MabezDev
Copy link
Member Author

Awesome!

@bors
Copy link
Contributor

bors bot commented May 27, 2019

Build failed

@adamgreig
Copy link
Member

adamgreig commented May 27, 2019 via email

@adamgreig
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request May 28, 2019
218: stm32h7x3: flash access and usart/uart confusion r=adamgreig a=richardeoin

Fix some subtle errors

* stm32h7: fix write-only and read-only registers in FLASH
* stm32h7: Fix confusion between USART and UART in RCC RSTR / ENR

219: Add missing crrcr reg for l4x3 series chips r=adamgreig a=MabezDev

It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that.

Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>
Co-authored-by: Scott Mabin <mabezdev@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 28, 2019

Build failed (retrying...)

bors bot added a commit that referenced this pull request May 28, 2019
219: Add missing crrcr reg for l4x3 series chips r=adamgreig a=MabezDev

It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that.

Co-authored-by: Scott Mabin <mabezdev@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 28, 2019

Build failed

@adamgreig
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request May 30, 2019
219: Add missing crrcr reg for l4x3 series chips r=adamgreig a=MabezDev

It appears #141 missed the crrcr register for the L4x3 chips, this PR addresses that.

Co-authored-by: Scott Mabin <mabezdev@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 30, 2019

Build succeeded

@bors bors bot merged commit e010f82 into stm32-rs:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking-change PR does not contain breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants