Fix write constraints for USART RDR and TDR registers #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The STM32F303 has 9 bit wide RDR and TDR registers and according to the
SVDs this is the case for all other devices with this peripheral too.
Make accessing TDR via tdr().bits() safe again by providing the
appropriate constraints.
The currently exisiting bitWidths have been quick-and-dirty checked
using:
svd $ xmllint --xpath ".//field[(name = 'RDR' or name = 'TDR') and bitWidth != 9]" --format *.svd *.svd.patched
bors bot
added a commit
to rust-embedded/discovery
that referenced
this pull request
Jun 21, 2021
354: Fix and clean up 11-usart by bumping dependencies r=adamgreig a=sirhcel This is an alternate version of #267 which fixes the panic by bumping dependencies. It also addresses the previously unsafe access to the USARTs transmit and receive data registers (TDR and RDR, stm32-rs/stm32-rs#558) by bumping the BSP to the brand spanking new release 0.7.0 which comes with a fixed PAC and HAL. Thank you very much @adamgreig, @Sh3Rm4n, and @rubberduck203 for your patience and support along this journey! This PR also bumps non-critical dependencies to their actual releases. For example `heapless`, which makes use of const generics nowadays. I did not succeed in getting `mdbook test` to actually check the example code. I moved it over to the `examples` directory and included it in the Markdown files so that it can be checked with `cargo build --target thumbv7em-none-eabihf --examples`. Co-authored-by: Christian Meusel <christian.meusel@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STM32F303 has 9 bit wide RDR and TDR registers and according to the SVDs this is the case for all other devices with this peripheral too. Make accessing TDR via tdr().bits() safe again by providing the appropriate constraints.
I stumbled upon this issue in rust-embedded/discovery#267 (comment).
The currently exisiting bitWidths have been quick-and-dirty checked using:
This gave not output while searching for
bitWidth = 9did.