Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enable UART DMA flags unconditionally #336

Merged
merged 3 commits into from Jul 13, 2021

Conversation

Windfisch
Copy link
Contributor

Fixes #334

I have not tested that code, though, so proceed with caution :)

@Windfisch Windfisch force-pushed the uart_dma_only_when_requested branch from dd9ef64 to 01635af Compare May 19, 2021 00:01
@Windfisch
Copy link
Contributor Author

Updated as per #334 (comment).

@Windfisch Windfisch force-pushed the uart_dma_only_when_requested branch from bd5e011 to 7040d39 Compare May 20, 2021 22:39
@Windfisch
Copy link
Contributor Author

Renamed serial-dma split and i2c free functions to release as per #334 (comment).

Copy link
Member

@TheZoq2 TheZoq2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I pointed out a few muts which cause warnings, other than that I think this is ready to merge (possibly after testing on hw)

src/serial.rs Outdated Show resolved Hide resolved
src/serial.rs Outdated Show resolved Hide resolved
@Windfisch Windfisch requested a review from TheZoq2 May 28, 2021 22:11
@burrbull
Copy link
Contributor

cc @TeXitoi

@TeXitoi TeXitoi merged commit 8a75825 into stm32-rs:master Jul 13, 2021
@TeXitoi
Copy link
Contributor

TeXitoi commented Jul 13, 2021

@burrbull you want acces right to this repo?

@burrbull
Copy link
Contributor

@burrbull you want acces right to this repo?

It would be great.

@TeXitoi
Copy link
Contributor

TeXitoi commented Jul 13, 2021

I can't find how to add you to the stm32f1 team, looks like I don't have the right or I can't find the settings

@adamgreig
Copy link
Member

Previously only @therealprof was a maintainer for the stm32f1 team, but I've added you as well @TeXitoi, so you should be able to add new team members now.

@TeXitoi
Copy link
Contributor

TeXitoi commented Jul 13, 2021

Thanks, @burrbull added.

@burrbull
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UARTs should not enable DMA by default
5 participants