Do not enable UART DMA flags unconditionally

CHANGELOG.md

@@ -20,10 +20,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fix > 2 byte i2c reads
 - Send stop after acknowledge errors on i2c
 - Fix i2c interactions after errors
-- Fix SPI3 alternate function remapping.
+- Fix SPI3 alternate function remapping
+- Do not enable UART DMA flags unconditionally
 
 ### Changed
 - Use `cortex-m-rtic` instead of `cortex-m-rtfm` in the examples
+- Renamed `serial`'s `RxDma`/`TxDma`'s `split` method into `release`
+- Renamed I2C's `free` method into `release`
 
 ## [v0.7.0]- 2020-10-17
 

src/i2c.rs

@@ -385,9 +385,14 @@ where
     }
 
     /// Releases the I2C peripheral and associated pins
-    pub fn free(self) -> (I2C, PINS) {
+    pub fn release(self) -> (I2C, PINS) {
         (self.i2c, self.pins)
     }
+
+    #[deprecated(since = "0.7.1", note = "Please use release instead")]
+    pub fn free(self) -> (I2C, PINS) {
+        self.release()
+    }
 }
 
 impl<I2C, PINS> BlockingI2c<I2C, PINS>

src/serial.rs

@@ -308,9 +308,6 @@ macro_rules! hal {
                             w.$usartX_remap().$bit(($closure)(PINS::REMAP))
                         });
 
-                    // enable DMA transfers
-                    usart.cr3.write(|w| w.dmat().set_bit().dmar().set_bit());
-
                     // Configure baud rate
                     let brr = <$USARTX as RccBus>::Bus::get_frequency(&clocks).0 / config.baudrate.0;
                     assert!(brr >= 16, "impossible baud rate");
@@ -547,6 +544,7 @@ macro_rules! serialdma {
 
             impl Rx<$USARTX> {
                 pub fn with_dma(self, channel: $dmarxch) -> $rxdma {
+                    unsafe { (*$USARTX::ptr()).cr3.write(|w| w.dmar().set_bit()); }
                     RxDma {
                         payload: self,
                         channel,
@@ -556,6 +554,7 @@ macro_rules! serialdma {
 
             impl Tx<$USARTX> {
                 pub fn with_dma(self, channel: $dmatxch) -> $txdma {
+                    unsafe { (*$USARTX::ptr()).cr3.write(|w| w.dmat().set_bit()); }
                     TxDma {
                         payload: self,
                         channel,
@@ -564,8 +563,13 @@ macro_rules! serialdma {
             }
 
             impl $rxdma {
+                #[deprecated(since = "0.7.1", note = "Please use release instead")]
                 pub fn split(mut self) -> (Rx<$USARTX>, $dmarxch) {
+                    self.release()
+                }
+                pub fn release(mut self) -> (Rx<$USARTX>, $dmarxch) {
                     self.stop();
+                    unsafe { (*$USARTX::ptr()).cr3.write(|w| w.dmar().clear_bit()); }
                     let RxDma {payload, channel} = self;
                     (
                         payload,
@@ -575,8 +579,13 @@ macro_rules! serialdma {
             }
 
             impl $txdma {
+                #[deprecated(since = "0.7.1", note = "Please use release instead")]
                 pub fn split(mut self) -> (Tx<$USARTX>, $dmatxch) {
+                    self.release()
+                }
+                pub fn release(mut self) -> (Tx<$USARTX>, $dmatxch) {
                     self.stop();
+                    unsafe { (*$USARTX::ptr()).cr3.write(|w| w.dmat().clear_bit()); }
                     let TxDma {payload, channel} = self;
                     (
                         payload,