Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subvariants #75

Merged
merged 12 commits into from
Apr 17, 2020
Merged

Subvariants #75

merged 12 commits into from
Apr 17, 2020

Conversation

strom-und-spiele
Copy link
Collaborator

Acts on the discussions in #67

@strom-und-spiele
Copy link
Collaborator Author

Travis fails b.c. it's running rustc […] --cfg 'feature="stm32f303"' which is what this PR is about…

Copy link
Member

@Sh3Rm4n Sh3Rm4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a breaking change (users which use the stm32f303 feature would not be able to compile there project anymore) I would introduce this change more gracefully.
I would like to see the use of th e deprecated attribute. I don't know how to apply it on features, though.

My thought is, that we have to give the user some time. So introduce a deprecation note in v0.5.0 and remove the features in v0.6.0. This would prevent the breaking of the code for users, which blindly update to v0.5.0 and give them some time to adjust there code.

Cargo.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ci/build.py Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Sh3Rm4n
Copy link
Member

Sh3Rm4n commented Mar 18, 2020

I really like the graphic included in the summary from stm (middle of the page)

I would not include this image in the README, but maybe an explanation about the code?

There is a perfect graphic in the datasheet (page 142 section 8) Not every information is relevant.

But on this part, I'm currently a bit confused. The Flash memory size letter is the one, which is referenced in the reference manual, on which distinction are made, which we replicate in the crate currently.

But I would think that the pin count [C, R, V] does determine how many gpio banks are available. I've to think about this part a little bit more.

strom-und-spiele added a commit to strom-und-spiele/stm32f3xx-hal that referenced this pull request Apr 7, 2020
This is discussed and will be attended to in PR stm32-rs#75
strom-und-spiele and others added 3 commits April 11, 2020 20:04
Co-Authored-By: Fabian <f.vioel@gmail.com>
Co-Authored-By: Fabian <f.vioel@gmail.com>
@strom-und-spiele
Copy link
Collaborator Author

There is a perfect graphic in the datasheet (page 142 section 8)[…]
But on this part, I'm currently a bit confused. The Flash memory size letter is the one, which is referenced in the reference manual, on which distinction are made, which we replicate in the crate currently.

This list does not seem to be exhaustive. It only helps you specifying the STM32F303x[BCDE] type of chips.
As far as I was involved, we discriminated between stm32f303x[BCDE] and stm32f303x[68].

README.md Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@Sh3Rm4n Sh3Rm4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like your description / documentation of the avaliabe features and how to choose them. I think this will greatly help newcomers.

So here is the (hopfully last) request for changes! :)

Thanks for your great work.

Cargo.toml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
README.md Show resolved Hide resolved
@Sh3Rm4n
Copy link
Member

Sh3Rm4n commented Apr 17, 2020

Thank you for this PR! :)

@Sh3Rm4n Sh3Rm4n merged commit 21310f9 into stm32-rs:master Apr 17, 2020
@strom-und-spiele strom-und-spiele deleted the subvariants branch April 17, 2020 18:27
@strom-und-spiele
Copy link
Collaborator Author

Should have "fixed" #81 by disallowing to select stm32f303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants