-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subvariants #75
Subvariants #75
Conversation
d50bcf1
to
19466a5
Compare
Travis fails b.c. it's running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a breaking change (users which use the stm32f303
feature would not be able to compile there project anymore) I would introduce this change more gracefully.
I would like to see the use of th e deprecated attribute. I don't know how to apply it on features, though.
My thought is, that we have to give the user some time. So introduce a deprecation note in v0.5.0
and remove the features in v0.6.0
. This would prevent the breaking of the code for users, which blindly update to v0.5.0
and give them some time to adjust there code.
I really like the graphic included in the summary from stm (middle of the page) I would not include this image in the README, but maybe an explanation about the code? There is a perfect graphic in the datasheet (page 142 section 8) Not every information is relevant. But on this part, I'm currently a bit confused. The Flash memory size letter is the one, which is referenced in the reference manual, on which distinction are made, which we replicate in the crate currently. But I would think that the pin count [C, R, V] does determine how many gpio banks are available. I've to think about this part a little bit more. |
This is discussed and will be attended to in PR stm32-rs#75
Co-Authored-By: Fabian <f.vioel@gmail.com>
Co-Authored-By: Fabian <f.vioel@gmail.com>
This list does not seem to be exhaustive. It only helps you specifying the STM32F303x[BCDE] type of chips. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like your description / documentation of the avaliabe features and how to choose them. I think this will greatly help newcomers.
So here is the (hopfully last) request for changes! :)
Thanks for your great work.
Co-Authored-By: Fabian <f.vioel@gmail.com>
Thank you for this PR! :) |
Should have "fixed" #81 by disallowing to select |
Acts on the discussions in #67