Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Arduino libraries dedicated for STM32 core into single repo #48

Closed
11 tasks done
fpistm opened this issue Jun 30, 2017 · 10 comments
Closed
11 tasks done

Move Arduino libraries dedicated for STM32 core into single repo #48

fpistm opened this issue Jun 30, 2017 · 10 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@fpistm
Copy link
Member

fpistm commented Jun 30, 2017

Purpose of this issue is to move Arduino libraries dedicated for STM32 core in separate repository.

I talk about libraries dedicated to hardware features: on board SD, Ethernet, LCD….
For purely software libraries, pull request should be done on dedicated github (ex: firmata,…) as far as possible else a repo could be created.

The core should only embed those for common hardware support (Wire/SPI/…).
As specified here:
https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-add-my-library-to-library-manager
So one library == a single repo.

ARDUINO_ARCH_STM32 must be used as differentiator.

This is a first approach any comments/suggestions are welcome. Mainly on repo name or way of working.

@fpistm fpistm added enhancement New feature or request help wanted 🙏 Extra attention is needed labels Jun 30, 2017
@Testato
Copy link
Contributor

Testato commented Jul 5, 2017

in my opinion open a repo for every library it is dispersive,
The lib can remain here, in a separate folder, the important think is that all library, in the file library.proprietry, change it's name from the arduino original name. Because the ArduinoIDE have problem on update when two lib have same name.

For example it is enough call the Wire library "Wire(STM32)"

All the library that do not have specific modification for STM32, for example firmata ? can remain on his repo, and completely deleted from here

@fpistm
Copy link
Member Author

fpistm commented Jul 5, 2017

Firmata need an update, I will do the pull request on the official repo to add support for the STM32 then I will delete it from the core.

Open a repo for each specific library allow to use Library manager from Arduino. Having all libraries in the core is not a good option. Many libraries are specific to a board (ex: ethernet is available only on few boards (F429zi, Disco746)) so this will increase core size while user will not use it. If user wants then he will have the possibility to install it.

@Testato
Copy link
Contributor

Testato commented Jul 6, 2017

It is true that you do not have ide library update, but if the lib is in the core it will updated when update the core by board manager, may be some modification on a lib needed by a core modification, in this case you can go out of sync.

Very big core peoject, like ESP, have it's modified lib inside the core. Another useful think is that when the libs is in the core you can immediately view how many lib you have so what you can do, without search for a lib without cechk if it is compatible.

But i know that also the separated github have advantage, like tracking of issue directly to a lib repo, instead of all togheter on the core repo

@fpistm
Copy link
Member Author

fpistm commented Aug 7, 2017

PR for Firmata merged in official repo.
Wainting new release version before removing it from the core.

@fpistm
Copy link
Member Author

fpistm commented Aug 20, 2017

Release of Firmata 2.5.7 available.

@fpistm fpistm self-assigned this Aug 20, 2017
@fpistm
Copy link
Member Author

fpistm commented Aug 23, 2017

TFT: pull request done: arduino-libraries/TFT#11
Required #90

@straccio
Copy link
Contributor

Another libraries could be:

  • OneWire (based on HAL)
  • FreeRTOS (that's will be awesome)
  • WolfSSL (really useful for IoT projects)

@fpistm
Copy link
Member Author

fpistm commented Nov 30, 2017

Right @straccio,
there's many libraries which could be fine to test/port.
This issue was opened for the one which was included in the core (built-in) at its beginning not to request some new library porting ;)

@straccio
Copy link
Contributor

Ok, Sorry!
but FreeRTOS is inside the stm32CubeFW ^^
Anyway i'll working on these libraries in the near future!

@fpistm
Copy link
Member Author

fpistm commented Nov 30, 2017

No worries ;)

@fpistm fpistm removed the help wanted 🙏 Extra attention is needed label Feb 12, 2019
@fpistm fpistm added this to the 1.5.0 milestone Feb 12, 2019
@fpistm fpistm closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants