Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make concurrency configurable #261

Merged
merged 4 commits into from
Jul 4, 2023
Merged

make concurrency configurable #261

merged 4 commits into from
Jul 4, 2023

Conversation

jpiper
Copy link
Contributor

@jpiper jpiper commented Jul 4, 2023

This allows the concurrency of HTTP client to be configured (it is 1 by default in order to maintain the existing behaviour). This also has the added benefit that a context cancellation will abort the lock acquisition

@stmcginnis
Copy link
Owner

Thanks! Any way we can accomplish this without using golang.org/x/sync? I know that library has had some security issues in the past, and I've been trying really hard to keep gofish from needing to pull in any extra dependencies.

@jpiper
Copy link
Contributor Author

jpiper commented Jul 4, 2023

yes I can rewrite this using a simple channel, I'll do that now for you

@jpiper
Copy link
Contributor Author

jpiper commented Jul 4, 2023

I think that does the trick

Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpiper!!

@stmcginnis stmcginnis merged commit a9184c6 into stmcginnis:main Jul 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants