Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-up the litex wrapper #722

Merged
merged 1 commit into from Nov 9, 2023
Merged

Fix-up the litex wrapper #722

merged 1 commit into from Nov 9, 2023

Conversation

Unike267
Copy link
Contributor

@Unike267 Unike267 commented Nov 7, 2023

Fix-up Litex wrapper

  • Board: ARTY A7 35T

Context:

I'm trying to implement the Neorv32 with Litex and with the deffault wrapper there is a failure with the SDRAM initialization. View enjoy-digital/litex#1802.

SDRAM_ERROR

I tried changing the wishbone protocol from pipelined to classic, and that seems to fix the issue.
It might have some effect in performance, but at least it works.
The following log shows that memory is correctly initialized.

SDRAM_OK

Looking forward, I believe there might be some conflict in the pipelined wishbone implementations of NEORV32 and Litex. @stnolting did you try the pipelined wishbone of NEORV32 with third-party wishbone peripherals?

/cc @enjoy-digital @umarcor

@enjoy-digital
Copy link
Contributor

Thanks @Unike267, I was just going to also look at it. Good to know you figured out the issue. It would probably be interesting to merge this PR and then see if we can enable burst with NeoRV32 and LiteX integration.

@stnolting stnolting self-assigned this Nov 9, 2023
@stnolting stnolting added bug Something isn't working HW hardware-related labels Nov 9, 2023
@stnolting
Copy link
Owner

Hey @Unike267,

thanks for fixing this!

tried changing the wishbone protocol from pipelined to classic, and that seems to fix the issue.
It might have some effect in performance, but at least it works.

That should not impact performance. Even with pipelined mode enabled there is just a single transfer "in flight".

did you try the pipelined wishbone of NEORV32 with third-party wishbone peripherals?

Yes I did and so far I did not see any issues.... 🤔

It would probably be interesting to merge this PR and then see if we can enable burst with NeoRV32 and LiteX integration.

Bursts access are still on the to-do list (#693) 😉

@stnolting stnolting merged commit c5cff6d into stnolting:main Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HW hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants