Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] close further illegal instruction loopholes #797

Merged
merged 2 commits into from Feb 9, 2024
Merged

[CPU] close further illegal instruction loopholes #797

merged 2 commits into from Feb 9, 2024

Conversation

stnolting
Copy link
Owner

fixing #796

@stnolting stnolting added bug Something isn't working risc-v compliance Modification to comply with official RISC-V specs. labels Feb 9, 2024
@stnolting stnolting self-assigned this Feb 9, 2024
@stnolting stnolting linked an issue Feb 9, 2024 that may be closed by this pull request
Compressed instruction decoder edge case not handled #796
Closed
@stnolting stnolting mentioned this pull request Feb 9, 2024
Closed
@stnolting stnolting marked this pull request as ready for review February 9, 2024 06:13
@stnolting
Copy link
Owner Author

@mikaelsky

The C tests of RISC-V arch-tests are passing ✔️
So I think we can merge this now and modify the decompressor in another PR if there are any loopholes left.

mikaelsky
mikaelsky approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@mikaelsky mikaelsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will do a post merge extra check.

@mikaelsky mikaelsky merged commit 35325df into main Feb 9, 2024
8 checks passed
@mikaelsky mikaelsky deleted the c_illegal_fix branch February 9, 2024 14:19
@mikaelsky
Copy link
Collaborator

@stnolting
Post merge check also passed. Ran a couple of thousand randomized illegal, undefined and reserved instructions through and the fix pass.
So we are good :)

@stnolting
Copy link
Owner Author

Great to hear! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelsky mikaelsky mikaelsky approved these changes

Assignees

@stnolting stnolting

Labels
bug Something isn't working risc-v compliance Modification to comply with official RISC-V specs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compressed instruction decoder edge case not handled
2 participants
@stnolting @mikaelsky