Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️⚠️ Rename external bus interface #846

Merged
merged 15 commits into from Mar 13, 2024
Merged

⚠️⚠️ Rename external bus interface #846

merged 15 commits into from Mar 13, 2024

Conversation

stnolting
Copy link
Owner

@stnolting stnolting commented Mar 12, 2024

⚠️ This is a major change!

As this caused some confusion (this bus is not explicitly reserved for connection processor-external memories) the external memory bus interface ("WISHBONE") is renamed: External Bus Interface (XBUS)

  • rename generics: MEM_EXT_* -> XBUS_*
  • rename Wishbone interface ports: wb_* -> xbus_*
  • rename Wishbone gateway rtl file: neorv32_wishbone.vhd -> neorv32_xbus.vhd
  • rename all external bus-related flags: MEM_EXT_* -> XBUS_*

@stnolting stnolting added the HW hardware-related label Mar 12, 2024
@stnolting stnolting self-assigned this Mar 12, 2024
@stnolting stnolting marked this pull request as ready for review March 12, 2024 21:06
Copy link
Collaborator

@NikLeberg NikLeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some forgotten renamings for the docs.
Besides that, it looks good to me. Didn't synthesize and test it though...
The rename makes sence, I remember also being slightly confused. 👍

docs/datasheet/soc_xbus.adoc Outdated Show resolved Hide resolved
docs/datasheet/soc_xbus.adoc Outdated Show resolved Hide resolved
docs/datasheet/soc_xbus.adoc Outdated Show resolved Hide resolved
docs/datasheet/soc_xbus.adoc Outdated Show resolved Hide resolved
docs/datasheet/soc_xbus.adoc Outdated Show resolved Hide resolved
docs/datasheet/soc_xbus.adoc Outdated Show resolved Hide resolved
rtl/core/neorv32_application_image.vhd Outdated Show resolved Hide resolved
stnolting and others added 8 commits March 13, 2024 16:09
Co-authored-by: NikLeberg <39563554+NikLeberg@users.noreply.github.com>
Signed-off-by: stnolting <stnolting@gmail.com>
Co-authored-by: NikLeberg <39563554+NikLeberg@users.noreply.github.com>
Signed-off-by: stnolting <stnolting@gmail.com>
Co-authored-by: NikLeberg <39563554+NikLeberg@users.noreply.github.com>
Signed-off-by: stnolting <stnolting@gmail.com>
Co-authored-by: NikLeberg <39563554+NikLeberg@users.noreply.github.com>
Signed-off-by: stnolting <stnolting@gmail.com>
Co-authored-by: NikLeberg <39563554+NikLeberg@users.noreply.github.com>
Signed-off-by: stnolting <stnolting@gmail.com>
Co-authored-by: NikLeberg <39563554+NikLeberg@users.noreply.github.com>
Signed-off-by: stnolting <stnolting@gmail.com>
from "demo_blink_led"
@stnolting stnolting merged commit 3ae47a8 into main Mar 13, 2024
10 checks passed
@stnolting stnolting deleted the xbus branch March 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HW hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants