Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotor consistently crashes on ≈10V mod input #365

Closed
Andreya-Autumn opened this issue Mar 7, 2023 · 3 comments
Closed

Rotor consistently crashes on ≈10V mod input #365

Andreya-Autumn opened this issue Mar 7, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Andreya-Autumn
Copy link

Hello! And big thanks for the useful modules. <3

I'm encountering the problem described in the title.
I'm on Rack Free 2.1.3, M1 Mac, OS11.6.5.
Attaching the crash log, and the patch that triggers it. (The patch needs some plugins, lemme know if you want me to set up a barebones repro patch).
Bringing the Bogaudio constant voltage to 10 crashes every time for me.
Rotor Crash.txt
SaunaDrone.vcv.zip

@stoermelder stoermelder self-assigned this Oct 3, 2023
@stoermelder stoermelder added the bug Something isn't working label Oct 3, 2023
stoermelder added a commit that referenced this issue Oct 3, 2023
@stoermelder
Copy link
Owner

Thanks for reporting, unfortunately I can't reproduce any crash with you patch. I tried it on Windows and I don't have an easy way to test it on a M1 Mac right now.
I reviewed the code and can only think of one issue which could occor by numeric precision while rounding numbers. I added some failsafe for this, but it needs confirmation. Please let me know if it still crashes using the latest build (I only provide x64 preview builds for Mac at the moment).
https://github.com/stoermelder/vcvrack-packone/releases/tag/Nightly

@Andreya-Autumn
Copy link
Author

Thanks! I managed to inadvertently install arm rack over intel rack recently so I gotta get a dual install going to test this. Maybe I'll find the time soon. The good news are I'm also not getting the crash anymore on Arm!

@stoermelder
Copy link
Owner

I close this issue for now. Feel free to respond if you experience more crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants