Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support timestampable and blameable for loggable #442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chapterjason
Copy link

By setting this priorities for the timestampable and blameable listener, the loggable listener will be called after them and also receives the changes made by the timestampable and blameable listener.

@chapterjason
Copy link
Author

CI is unrelated, just looks like some deprecation messages makes them fail. (IIRC the deprecation message makes PHPUnit return with exit_code != 0)

@chapterjason
Copy link
Author

chapterjason commented Aug 21, 2023

I came across this issue again and noticed that sluggable is also affected.

// EDIT: sorry for close and reopen, wrong button. 😄

@chapterjason
Copy link
Author

Hello @stof

this is still an issue, I also noticed some other PR about make it configurable. (#384)
Can you please have a look on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant