feat: set openerTabId to tabs opened from links (#471)

stoically · Oct 9, 2020 · d2e904e · d2e904e
1 parent 083b523
commit d2e904e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/background/container.ts b/src/background/container.ts
@@ -65,6 +65,7 @@ export class Container {
     dontPin = true,
     deletesHistory = false,
     macConfirmPage = false,
+    openerTab,
   }: TmpTabOptions): Promise<Tab | undefined> {
     if (request && request.requestId) {
       // we saw that request already
@@ -98,6 +99,7 @@ export class Container {
       dontPin,
       macConfirmPage,
       contextualIdentity,
+      openerTab,
     });
   }
 
@@ -165,13 +167,15 @@ export class Container {
     dontPin,
     macConfirmPage,
     contextualIdentity,
+    openerTab,
   }: {
     url?: string;
     tab?: Tab;
     active?: boolean;
     dontPin?: boolean;
     macConfirmPage?: boolean;
     contextualIdentity: browser.contextualIdentities.ContextualIdentity;
+    openerTab?: Tab;
   }): Promise<Tab> {
     try {
       const newTabOptions: CreateTabOptions = {
@@ -212,7 +216,9 @@ export class Container {
         if (tab.pinned && !dontPin) {
           newTabOptions.pinned = true;
         }
-        if (tab.openerTabId) {
+        if (openerTab) {
+          newTabOptions.openerTabId = openerTab.id;
+        } else if (tab.openerTabId) {
           newTabOptions.openerTabId = tab.openerTabId;
         }
         if (tab.windowId) {

diff --git a/src/background/contextmenu.ts b/src/background/contextmenu.ts
@@ -30,6 +30,7 @@ export class ContextMenu {
           active: false,
           deletesHistory:
             this.pref.deletesHistory.automaticMode === 'automatic',
+          openerTab: tab,
         });
         break;
 
@@ -39,6 +40,7 @@ export class ContextMenu {
           url: info.linkUrl,
           active: false,
           deletesHistory: true,
+          openerTab: tab,
         });
         break;
 

diff --git a/src/types.ts b/src/types.ts
@@ -47,6 +47,7 @@ export interface TmpTabOptions {
   dontPin?: boolean;
   deletesHistory?: boolean;
   macConfirmPage?: boolean;
+  openerTab?: Tab;
 }
 
 export type IsolationAction =