Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify opener tab information to new temporary container tabs opened from links #471

Merged

Conversation

piroor
Copy link
Contributor

@piroor piroor commented Oct 9, 2020

I got a compatibility issue report piroor/treestyletab#2720 about a combination of two extensions: Tree Style Tab and Temporary Container. After a research I've realized that Temporary Containers doesn't set any opener tab information to tabs even if they are explicitly opened from links. This PR appends ability to set opener tab information to new temporary container tab on such cases. How about this change?

@piroor
Copy link
Contributor Author

piroor commented Oct 9, 2020

I think this change will improve compatibility with more tab related addons not only Tree Style Tab.

@piroor piroor force-pushed the specify-opener-tab-for-tabs-from-links branch from 9564acb to fe1f767 Compare October 9, 2020 06:19
Copy link
Owner

@stoically stoically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@stoically stoically merged commit d2e904e into stoically:main Oct 9, 2020
@piroor
Copy link
Contributor Author

piroor commented Oct 9, 2020

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants