Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method generate(org.codehaus.doxia.sink.Sink sink, java.util.Loca… #1165

Closed
wants to merge 1 commit into from

Conversation

agaengel
Copy link
Contributor

…le locale) to avoid maven site error

@stoicflame
Copy link
Owner

I'm afraid this isn't going to work because org.codehaus.doxia.sink.Sink doesn't extend or implement org.apache.maven.doxia.sink.Sink.

@stoicflame stoicflame closed this Mar 21, 2023
@agaengel
Copy link
Contributor Author

@stoicflame it's correct that it does not extend the method but it works just try with the test project

I think that some maven process checks via reflection if the method with the right signature is present

Regards
Alex

@fhm84
Copy link

fhm84 commented Nov 6, 2023

Hi @stoicflame we just tested enunciate 2.17.1 on maven 3.9.5 (java 21) using maven-site-plugin:3.12.1 ... unfortunatelly, it didn't work, because of missing method exception. But we found a way to get it run (and from my point of view, this should also be backwards-compatible). Even if in the meanwhile org.codehaus.doxia.sink.Sink extends org.apache.maven.doxia.sin.Sink, I think we just could/should provide 2 generate-methods: one for each type. And by removing @Overwrite annotation, from my point of view, we might also be "safe" for the future ;) - especially, because currently this sink is not used within this method.

@stoicflame
Copy link
Owner

At a6f7fe9 I implemented @fhm84 's suggestion. I haven't tested it on Maven 3.9.5 yet, though.

@fhm84
Copy link

fhm84 commented Nov 6, 2023

Ok, cool. Thanks @stoicflame . As I already wrote, we tested this approach with maven 3.9.5 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants