Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

futurizing stage 2 geometry and cleaning #31

Merged
merged 3 commits into from Jan 10, 2020
Merged

futurizing stage 2 geometry and cleaning #31

merged 3 commits into from Jan 10, 2020

Conversation

rkwi
Copy link

@rkwi rkwi commented Jan 10, 2020

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 41.793% when pulling 5c2aea5 on rkwi:anuga_py3 into 9d4ca4d on stoiver:anuga_py3.

@rkwi
Copy link
Author

rkwi commented Jan 10, 2020

Stage 2 will change all old style class declarations into new style class declarations. For instance in quad.py 'class cell' will be changed into 'class cell(object)'. In Python 3, any old style class declaration is considered as the later. Unfortunately, this causes issues when we try to use pickle.loads to read an instance of a new style class. Currently, I manually changed it back into 'class cell', but we have to solve this later, maybe by including the init arguments inside the stored byte object.

@stoiver stoiver merged commit 5088481 into stoiver:anuga_py3 Jan 10, 2020
stoiver added a commit that referenced this pull request Nov 5, 2022
Removed the old_div function calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants