Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-3514 - track ClusterManagementAddons in toggleable component status #394

Conversation

JakobGray
Copy link
Collaborator

Jira: https://issues.redhat.com/browse/ACM-3514

On the off chance that the ClusterManagementAddon resource is not deployed while applying a component, it will be identified in the MCE.

In the status it will look like the below:

  status:
    components:
    - kind: ClusterManagementAddOn
      name: managed-serviceaccount
      reason: ComponentsDeployed
      status: "True"
      type: Present
    - kind: ClusterManagementAddOn
      name: hypershift-addon
      reason: ComponentsDeployed
      status: "True"
      type: Present
    - kind: ClusterManagementAddOn
      name: cluster-proxy
      reason: ComponentsDeployed
      status: "True"
      type: Present

…ence

Signed-off-by: Jakob Gray <20209054+JakobGray@users.noreply.github.com>
Signed-off-by: Jakob Gray <20209054+JakobGray@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

84.1% 84.1% Coverage
6.3% 6.3% Duplication

@cameronmwall
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, JakobGray

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JakobGray,cameronmwall]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a7db8cb into stolostron:main Mar 7, 2023
@JakobGray JakobGray deleted the ACM-3514-track-clustermanagementaddons branch March 7, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants