-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃 Sync from open-cluster-management-io/config-policy-controller: #223, #226 #797
Conversation
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> (cherry picked from commit 7c98e1d57b3b88f781e177e7a7571d6bdca35fb1)
If a field exists in the object but wasn't defined for a mustonlyhave policy, we need to check the existing object's fields and set them accordingly, particularly to set them to null. ref: https://issues.redhat.com/browse/ACM-10877 Co-authored-by: Matt Prahl <mprahl@users.noreply.github.com> Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> (cherry picked from commit 5f1d26aa4093c5e24112123eab01354930d943db)
Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit c7624121c0d12c79934a8f115695ce080e69ccac)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.10 |
@mprahl: new pull request created: #800 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs:
mustonlyhave
聽open-cluster-management-io/config-policy-controller#223This replaces #796.
Closes #798
Closes #799