[release-2.9] Cherry-pick: Fix handling of undefined fields for mustonlyhave
#801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> (cherry picked from commit 7c98e1d57b3b88f781e177e7a7571d6bdca35fb1)
|
This cherry-pick also isn't mandatory per se since the Jira was never actually attached to the support case for 2.9, but might as well do my due diligence? |
|
@dhaiducek could you please fix the linting error? |
dhaiducek
force-pushed
the
cherry-pick-mustnothave
branch
from
67196c8
to
d69c42c
Compare
mprahl
previously approved these changes
Apr 15, 2024
If a field exists in the object but wasn't defined for a mustonlyhave policy, we need to check the existing object's fields and set them accordingly, particularly to set them to null. ref: https://issues.redhat.com/browse/ACM-10877 Co-authored-by: Matt Prahl <mprahl@users.noreply.github.com> Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> (cherry picked from commit 5f1d26aa4093c5e24112123eab01354930d943db) Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
cherry-pick-mustnothave
branch
from
d69c42c
to
5c2f84a
Compare
mprahl
approved these changes
Apr 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
openshift-merge-bot
bot
merged commit 13b0f4b
into
stolostron:release-2.9
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function the code was put in was refactored, but I think I found where it was refactored from...
Manual cherry-pick of commit from: