Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #276 #870

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

TomerFi and others added 2 commits November 7, 2022 16:55
…#277)

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
(cherry picked from commit f4e020ab36888820fb97afb2f4cd885c0e2ecb8e)
…notation defined or the git path is the current repo (#276)

* Fix Git subscription for Helm charts with no git path subscription annotation defined or the git path is the current repo

Signed-off-by: Mike Ng <ming@redhat.com>

* update e2e test to use internal helm repo instead of public one to avoid unexpected update changes

Signed-off-by: Mike Ng <ming@redhat.com>

Signed-off-by: Mike Ng <ming@redhat.com>
(cherry picked from commit 9f748e3134ea91c898ddd4a63f74a242490becda)
@mikeshng
Copy link
Contributor

mikeshng commented Nov 7, 2022

/approve

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: magic-mirror-bot[bot], mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2022
@mikeshng
Copy link
Contributor

mikeshng commented Nov 7, 2022

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.0% 48.0% Coverage
1.2% 1.2% Duplication

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

@magic-mirror-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud cd7affd link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikeshng
Copy link
Contributor

mikeshng commented Nov 7, 2022

Additional e2e tests will be added to enhance test coverage.

@mikeshng mikeshng merged commit feb9ade into main Nov 7, 2022
@mikeshng mikeshng deleted the magic-mirror-main-1667840135919 branch November 7, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants