WIP Update resources in Hub Metrics collection & Fix e2e #1351

coleenquadros · 2024-02-27T22:10:07Z

Toggling hubselfmanagement multiple times creates addon-observability namespace in hub cluster intermittently. This PR ensure we skip any reconcile in MCO touching local-cluster object
Update hub metrics collections resources when modified
FIx e2e tests

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

…#1353) * scripts: Create script to install dependencies/tools Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * make: Add target to install build deps Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * make: Include go mod work and required deps in build step Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * ci: Remove extra operator-sdk install script Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * ci: Remove extra step which is now included in make target Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * make: run 'bundle' target and commit Dockerfile diff Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * scripts: Add kustomize as a build dependency Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * make: Add target to build mco bin locally Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * docs: Add dev documentation Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * git: Add ignore to generated dir Signed-off-by: Philip Gough <philip.p.gough@gmail.com> --------- Signed-off-by: Philip Gough <philip.p.gough@gmail.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* ci: Remove unreferenced scripts Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * test: Remove unused function call and code Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * test: Clean up test script Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * docs: Tidy up simulator docs Signed-off-by: Philip Gough <philip.p.gough@gmail.com> --------- Signed-off-by: Philip Gough <philip.p.gough@gmail.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* init Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add cm watcher Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * cleaning Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * change rbac-proxy image Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix namespaces names Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix unit tests Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix serviceMonitor namespace Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add e2e test debug info Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add mch-image-manifest debug info Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve image replacement logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix call to image replacer Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add service monitor crd to kind e2e Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add debug logging oba e2e tests Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve logs, reduce volume Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve ci logs Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve ci logs Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add oba logs Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve oba logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add unit tests Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add apiextensionsv1 scheme Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add resource version to crd update Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* scripts: Add function to install KinD Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * make: Add target for e2e test tools Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * ci: Remove duplicate dep checks from script Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * make: Add bin dir to install deps Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * ci: Remove PATH overwrite and add tmp generated bin dir to git ignore Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * ci: Ensure required bins are copied to ec2-user Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * ci: Fetch LATEST_SNAPSHOT and inject into prow env Signed-off-by: Philip Gough <philip.p.gough@gmail.com> --------- Signed-off-by: Philip Gough <philip.p.gough@gmail.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

coleenquadros · 2024-03-01T16:14:01Z

/retest

coleenquadros · 2024-03-01T17:11:33Z

/retest

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

openshift-ci · 2024-03-04T13:22:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [coleenquadros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-03-06T13:22:46Z

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

853ae0d Merge branch 'main' into res_update
32a53e7 Merge branch 'main' into res_update
77934b3 Merge branch 'main' into res_update
c5438cf Delete test_cluster
be7596d Merge branch 'main' into res_update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sonarcloud · 2024-03-06T13:28:23Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

openshift-ci · 2024-03-06T13:34:33Z

@coleenquadros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test-e2e	`77934b3`	link	true	`/test test-e2e`
ci/prow/sonarcloud	`be7596d`	link	true	`/test sonarcloud`
ci/prow/e2e-kind	`be7596d`	link	true	`/test e2e-kind`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

coleenquadros · 2024-03-06T13:43:34Z

continued here -> #1371

openshift-ci bot added the dco-signoff: yes label Feb 27, 2024

coleenquadros added do-not-merge/work-in-progress and removed dco-signoff: yes labels Feb 27, 2024

openshift-ci bot added approved dco-signoff: yes and removed do-not-merge/work-in-progress labels Feb 27, 2024

coleenquadros changed the title ~~avoid addon namespace~~ avoid addon-observability namespace in Hub Feb 27, 2024

coleenquadros changed the title ~~avoid addon-observability namespace in Hub~~ Update resources in Hub Metrics collection & Fix e2e Feb 28, 2024

coleenquadros changed the title ~~Update resources in Hub Metrics collection & Fix e2e~~ WIP Update resources in Hub Metrics collection & Fix e2e Feb 28, 2024

openshift-ci bot added do-not-merge/work-in-progress dco-signoff: no and removed dco-signoff: yes labels Feb 28, 2024

coleenquadros requested a review from clyang82 March 1, 2024 09:00

coleenquadros and others added 17 commits March 1, 2024 12:27

avoid addon namespace

27dfaf6

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

avoid addon namespace

6a88e5f

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

avoid addon namespace

6b2ef55

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

fix obs add on e2e test

542ea3c

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

make metrics collector use managed cert

90abd8c

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

ignore test cases for local-cluster

223176f

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

fix e2e

76ac152

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

fix e2e

966d6a7

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

fix tests

f5f33a4

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

logs for e2e

90cdb46

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

logs for e2e

2ba2963

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

test

9d9bafa

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

test

8dbf7f3

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

coleenquadros force-pushed the res_update branch from 15e14aa to fa5fe12 Compare March 1, 2024 11:28

openshift-ci bot added dco-signoff: yes and removed dco-signoff: no labels Mar 1, 2024

Merge branch 'main' into res_update

853ae0d

openshift-ci bot added dco-signoff: no and removed dco-signoff: yes labels Mar 1, 2024

coleenquadros added 2 commits March 1, 2024 18:12

Merge branch 'main' into res_update

32a53e7

test logs

4d1111c

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

coleenquadros added 3 commits March 5, 2024 14:34

Merge branch 'main' into res_update

77934b3

Delete test_cluster

c5438cf

Merge branch 'main' into res_update

be7596d

coleenquadros closed this Mar 6, 2024

coleenquadros deleted the res_update branch April 16, 2024 16:44

subbarao-meduri mentioned this pull request Jun 18, 2024

Install metrics without addon #1311

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Update resources in Hub Metrics collection & Fix e2e #1351

WIP Update resources in Hub Metrics collection & Fix e2e #1351

coleenquadros commented Feb 27, 2024 •

edited

Loading

coleenquadros commented Mar 1, 2024

coleenquadros commented Mar 1, 2024

openshift-ci bot commented Mar 4, 2024

openshift-ci bot commented Mar 6, 2024

sonarcloud bot commented Mar 6, 2024

openshift-ci bot commented Mar 6, 2024

coleenquadros commented Mar 6, 2024

WIP Update resources in Hub Metrics collection & Fix e2e #1351

WIP Update resources in Hub Metrics collection & Fix e2e #1351

Conversation

coleenquadros commented Feb 27, 2024 • edited Loading

coleenquadros commented Mar 1, 2024

coleenquadros commented Mar 1, 2024

openshift-ci bot commented Mar 4, 2024

openshift-ci bot commented Mar 6, 2024

sonarcloud bot commented Mar 6, 2024

Quality Gate failed

openshift-ci bot commented Mar 6, 2024

coleenquadros commented Mar 6, 2024

coleenquadros commented Feb 27, 2024 •

edited

Loading