Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(StoneDB 8.0): dd::Table * is added by MySQL 8.0 in handle api #595

Closed
DandreChen opened this issue Sep 28, 2022 · 1 comment
Closed
Assignees
Labels
A-feature feature with good idea C-stonedb-8.0 associated with stonedb 8.0

Comments

@DandreChen
Copy link
Collaborator

DandreChen commented Sep 28, 2022

Is your feature request related to a problem? Please describe.

handle api is added dd::Table * parameter,as below:

  1. int delete_table(const char *from, const dd::Table *table_def) override;
  2. int rename_table(const char *from, const char *to, const dd::Table *from_table_def, dd::Table *to_table_def) override;
  3. int create(const char *name, TABLE *table_arg, HA_CREATE_INFO *info, dd::Table *table_def) override; 
  4. bool inplace_alter_table(TABLE *altered_table [[maybe_unused]], Alter_inplace_info *ha_alter_info                              [[maybe_unused]],  const dd::Table *old_table_def [[maybe_unused]],  dd::Table *new_table_def [[maybe_unused]]) override;
  5. bool commit_inplace_alter_table(TABLE *altered_table [[maybe_unused]], Alter_inplace_info *ha_alter_info [[maybe_unused]],
 bool commit [[maybe_unused]], const dd::Table *old_table_def [[maybe_unused]],dd::Table *new_table_def [[maybe_unused]]) override;
  6. int truncate(dd::Table *table_def) override;

Describe the solution you'd like

adapt the code for MySQL 8.0

Describe alternatives you've considered

Additional context

@DandreChen DandreChen added A-feature feature with good idea C-stonedb-8.0 associated with stonedb 8.0 labels Sep 28, 2022
@DandreChen DandreChen added this to the stonedb_8.0_v1.0.0 milestone Sep 28, 2022
DandreChen added a commit to DandreChen/stonedb that referenced this issue Sep 29, 2022
…dle api. (stoneatom#595)

[summary]
1 Add 'dd::Table *' type parameter in tianmu engine to indicate the parameter;
DandreChen added a commit to DandreChen/stonedb that referenced this issue Sep 30, 2022
…dle api. (stoneatom#595)

[summary]
1 Add 'dd::Table *' type parameter in tianmu engine to indicate the parameter;
DandreChen added a commit to DandreChen/stonedb that referenced this issue Sep 30, 2022
…dle api. (stoneatom#595)

[summary]
1 Add 'dd::Table *' type parameter in tianmu engine to indicate the parameter;
mergify bot pushed a commit that referenced this issue Sep 30, 2022
…dle api. (#595)

[summary]
1 Add 'dd::Table *' type parameter in tianmu engine to indicate the parameter;
@lujiashun
Copy link

DD table Reference:
https://blog.csdn.net/solihawk/article/details/120427599

@DandreChen DandreChen self-assigned this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-feature feature with good idea C-stonedb-8.0 associated with stonedb 8.0
Projects
Development

No branches or pull requests

2 participants