Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Dose not support the ALTER syntax, ALTER table t1 rename t2, add c char(10); #760

Closed
davidshiz opened this issue Oct 20, 2022 · 1 comment · Fixed by #901
Closed

feature: Dose not support the ALTER syntax, ALTER table t1 rename t2, add c char(10); #760

davidshiz opened this issue Oct 20, 2022 · 1 comment · Fixed by #901
Assignees
@DandreChen
Labels
A-feature feature with good idea prio: high High priority
Milestone
StoneDB_5.7_v1.0.2

Comments

@davidshiz
Copy link
Collaborator

Describe the solution you'd like

Suggest to support the ALTER sytax :
ALTER table t1 rename t2, add c char(10);

Additional context

The current situation is as follows：

mysql> create table t1 (i int primary key);
Query OK, 0 rows affected (0.00 sec)

mysql> alter table t1 rename t2, add c char(10);
ERROR 2233 (HY000): Be disgraceful to storage engine, operating is forbidden!
@davidshiz davidshiz added the A-feature feature with good idea label Oct 20, 2022
@davidshiz davidshiz added this to the stonedb_5.7_v1.0.2 milestone Oct 20, 2022
@DandreChen
Copy link
Collaborator

ACK

@RingsC RingsC added the prio: high High priority label Nov 1, 2022
DandreChen added a commit to DandreChen/stonedb that referenced this issue Nov 8, 2022
@DandreChen
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
00b05c1 
…c char(10) (stoneatom#760)

fix some warnings
add mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
@DandreChen DandreChen mentioned this issue Nov 8, 2022
Merged
15 tasks
DandreChen added a commit to DandreChen/stonedb that referenced this issue Nov 9, 2022
@DandreChen
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
1d83c81 
…c char(10) (stoneatom#760)

fix some warnings
add mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
DandreChen added a commit to DandreChen/stonedb that referenced this issue Nov 9, 2022
@DandreChen
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
e60700d 
…c char(10) (stoneatom#760)

fix some warnings
add mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
DandreChen added a commit to DandreChen/stonedb that referenced this issue Nov 9, 2022
@DandreChen
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
9b6bd0a 
…c char(10) (stoneatom#760)

fix some warnings
add mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
DandreChen added a commit to DandreChen/stonedb that referenced this issue Nov 10, 2022
@DandreChen
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
fe291bf 
…c char(10) (stoneatom#760)

fix some warnings
add mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
DandreChen added a commit to DandreChen/stonedb that referenced this issue Nov 10, 2022
@DandreChen
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
e1910bd 
…c char(10) (stoneatom#760)

fix some warnings
add/fix mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
@mergify mergify bot closed this as completed in #901 Nov 10, 2022
mergify bot pushed a commit that referenced this issue Nov 10, 2022
@DandreChen @mergify
feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add …
02cb94c 
…c char(10) (#760)

fix some warnings
add/fix mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
@hustjieke hustjieke mentioned this issue May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DandreChen DandreChen

Labels
A-feature feature with good idea prio: high High priority
Projects
None yet
Milestone
StoneDB_5.7_v1.0.2
3 participants
@RingsC @DandreChen @davidshiz