Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu):The myloader cann't work if the autocommit is closed. (#1510) #1524

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Apr 4, 2023

Currently, TIANMU does not support manual transactions and only supports automatic commit. However, it does determine whether to commit the transaction based on the automatic commit parameters of MySQL. If automatic commit is turned off, automatic commit will not be performed on the transaction

Summary about this PR

Issue Number: close #1510

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Apr 4, 2023
@konghaiya konghaiya force-pushed the dev_lhj_1510 branch 3 times, most recently from 67cf1cd to 7dcf42c Compare April 4, 2023 07:38
@konghaiya konghaiya self-assigned this Apr 4, 2023
…oneatom#1510)

Currently, TIANMU does not support manual transactions and only supports automatic commit.
However, it does determine whether to commit the transaction based on the automatic commit parameters of MySQL.
If automatic commit is turned off, automatic commit will not be performed on the transaction
@haitaoguan haitaoguan self-requested a review April 6, 2023 02:23
@mergify mergify bot merged commit 9d45726 into stoneatom:stonedb-5.7-dev Apr 6, 2023
@konghaiya konghaiya deleted the dev_lhj_1510 branch April 18, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: The myloader cann't work if the autocommit is closed.
3 participants