Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): mv func from public to protected(#1501) #1527

Merged
merged 6 commits into from
Apr 5, 2023
Merged

feat(tianmu): mv func from public to protected(#1501) #1527

merged 6 commits into from
Apr 5, 2023

Conversation

zzzz-vincent
Copy link
Contributor

Summary about this PR

Issue Number: close #1501

  1. change some magic numbers to const variables for readability
  2. extract long method to helper function
  3. removed unnecessary paraphrases

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Apr 4, 2023
hustjieke
hustjieke approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hustjieke
Copy link
Collaborator

cc @RingsC @wisehead please take a CR

@Nliver
Copy link
Collaborator

Nliver commented Apr 4, 2023

Nice job~@zzzz-vincent

@mergify mergify bot merged commit 59e9174 into stoneatom:stonedb-5.7-dev Apr 5, 2023
@Nliver Nliver added this to the stonedb_5.7_v1.0.4 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC approved these changes

@hustjieke hustjieke hustjieke approved these changes

@wisehead wisehead Awaiting requested review from wisehead

Assignees

@zzzz-vincent zzzz-vincent

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.4
Development

Successfully merging this pull request may close these issues.

feature: mv function from public to protected
4 participants
@zzzz-vincent @hustjieke @Nliver @RingsC