Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optmizer):fix the crashes when the right table of hash join is in parallel(#1538) #1541

Conversation

wisehead
Copy link
Collaborator

…s enabled of the right table #1538

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +45.08 🎉

Comparison is base (44d6ff8) 0.00% compared to head (643798b) 45.08%.

❗ Current head 643798b differs from pull request most recent head e03ec8c. Consider uploading reports for the commit e03ec8c to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1541       +/-   ##
====================================================
+ Coverage                 0   45.08%   +45.08%     
====================================================
  Files                    0     1999     +1999     
  Lines                    0   413915   +413915     
====================================================
+ Hits                     0   186597   +186597     
- Misses                   0   227318   +227318     
Impacted Files Coverage Δ
storage/tianmu/core/parallel_hash_join.cpp 0.62% <ø> (ø)

... and 1998 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wisehead wisehead force-pushed the bug1538_hash_join_parallel_on_right_table_crash branch from 5924abf to 129f663 Compare April 10, 2023 13:27
@wisehead wisehead force-pushed the bug1538_hash_join_parallel_on_right_table_crash branch from 129f663 to 643798b Compare April 11, 2023 01:58
Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 758bce8 into stoneatom:stonedb-5.7-dev Apr 11, 2023
@Nliver Nliver added this to the stonedb_5.7_v1.0.4 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants