Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu):Support insert ignore syntax (#1637) #1643

Merged
merged 2 commits into from
May 4, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Apr 28, 2023

Summary about this PR

Issue Number: close #1637

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +55.23 🎉

Comparison is base (4a35d96) 0.00% compared to head (5611dcb) 55.23%.

❗ Current head 5611dcb differs from pull request most recent head 88abea7. Consider uploading reports for the commit 88abea7 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1643       +/-   ##
====================================================
+ Coverage                 0   55.23%   +55.23%     
====================================================
  Files                    0     2031     +2031     
  Lines                    0   431433   +431433     
====================================================
+ Hits                     0   238286   +238286     
- Misses                   0   193147   +193147     
Impacted Files Coverage Δ
storage/tianmu/core/engine.cpp 67.11% <ø> (ø)
storage/tianmu/core/engine.h 29.16% <ø> (ø)
storage/tianmu/core/tianmu_table.h 87.50% <ø> (ø)
storage/tianmu/handler/ha_tianmu.cpp 51.65% <ø> (ø)
storage/tianmu/core/tianmu_table.cpp 67.73% <100.00%> (ø)

... and 2026 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@konghaiya konghaiya self-assigned this May 4, 2023
@mergify mergify bot merged commit 57e3497 into stoneatom:stonedb-5.7-dev May 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Support insert ignore syntax
3 participants