Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): Insert ignore can insert duplicate values.(#1699) #1746

Merged
merged 2 commits into from
May 9, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented May 8, 2023

Summary about this PR

Issue Number: close #1699

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label May 8, 2023
@konghaiya konghaiya self-assigned this May 8, 2023
@Nliver Nliver requested a review from RingsC May 8, 2023 09:21
@Nliver Nliver added this to the StoneDB_5.7_v1.0.4 milestone May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (2daac7c) 55.20% compared to head (08b3ab5) 55.27%.

❗ Current head 08b3ab5 differs from pull request most recent head 1f63818. Consider uploading reports for the commit 1f63818 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1746      +/-   ##
===================================================
+ Coverage            55.20%   55.27%   +0.06%     
===================================================
  Files                 2031     2031              
  Lines               431436   431436              
===================================================
+ Hits                238171   238469     +298     
+ Misses              193265   192967     -298     
Impacted Files Coverage Δ
storage/tianmu/core/engine.cpp 67.11% <100.00%> (ø)

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit 74b5b05 into stoneatom:stonedb-5.7-dev May 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

bug: Insert ignore can insert duplicate values.
4 participants