Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix error occurred in the union all query result (#1599) #1750

Merged
merged 2 commits into from
May 9, 2023
Merged

fix(tianmu): fix error occurred in the union all query result (#1599) #1750

merged 2 commits into from
May 9, 2023

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented May 8, 2023

Summary about this PR

Issue Number: close #1599

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label May 8, 2023
Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (74b5b05) 55.18% compared to head (5817acf) 55.16%.

❗ Current head 5817acf differs from pull request most recent head 31ae1c3. Consider uploading reports for the commit 31ae1c3 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1750      +/-   ##
===================================================
- Coverage            55.18%   55.16%   -0.03%     
===================================================
  Files                 2031     2031              
  Lines               431436   431443       +7     
===================================================
- Hits                238081   237986      -95     
- Misses              193355   193457     +102     
Impacted Files Coverage Δ
storage/tianmu/core/engine.h 29.16% <ø> (ø)
storage/tianmu/core/engine_results.cpp 85.84% <100.00%> (+0.31%) ⬆️

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit a33ba87 into stoneatom:stonedb-5.7-dev May 9, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
3 participants