New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tianmu): remove DBUG_OFF and repalce DEBUG_ASSERT with assert #1751
feat(tianmu): remove DBUG_OFF and repalce DEBUG_ASSERT with assert #1751
Conversation
This pull request's title should follow requirements next. @duanjr please check it 👇. Valid format:
Valid types:
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Greate job! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1751 +/- ##
===================================================
+ Coverage 55.18% 55.20% +0.02%
===================================================
Files 2031 2031
Lines 431436 431424 -12
===================================================
+ Hits 238081 238181 +100
+ Misses 193355 193243 -112
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary about this PR
feat: remove DBUG_OFF flag and repalce DEBUG_ASSERT with assert in tianmu engine(#1551)
1.Remove the code segment in
common/assert.h
2.Automatically replace DBUG_ASSERT with assert in all files under tianmu directory.
3.Manually adjust indent in
core/query.cpp
andoptimizer/compile/descriptor.cpp
[Edited]4.Automatically update fomat use clang-format after first check failed.
Tests Check List
Changelog
Documentation