Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix Error result set of the IN subquery with semi join (#1764) #1770

Merged
merged 2 commits into from
May 11, 2023
Merged

fix(tianmu): fix Error result set of the IN subquery with semi join (#1764) #1770

merged 2 commits into from
May 11, 2023

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented May 11, 2023

Summary about this PR

Issue Number: close #1764

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label May 11, 2023
Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 94.44% and project coverage change: -0.03 ⚠️

Comparison is base (74b5b05) 55.18% compared to head (efffe13) 55.15%.

❗ Current head efffe13 differs from pull request most recent head f3c4a09. Consider uploading reports for the commit f3c4a09 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1770      +/-   ##
===================================================
- Coverage            55.18%   55.15%   -0.03%     
===================================================
  Files                 2031     2031              
  Lines               431436   431427       -9     
===================================================
- Hits                238081   237958     -123     
- Misses              193355   193469     +114     
Impacted Files Coverage Δ
storage/tianmu/core/engine.h 29.16% <ø> (ø)
storage/tianmu/core/tianmu_table.cpp 67.84% <ø> (+0.11%) ⬆️
sql/sql_optimizer.cc 79.40% <83.33%> (+0.14%) ⬆️
sql/sql_resolver.cc 72.99% <100.00%> (-12.66%) ⬇️
storage/tianmu/core/engine_results.cpp 85.84% <100.00%> (+0.31%) ⬆️

... and 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit c3931fe into stoneatom:stonedb-5.7-dev May 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Error result set of the IN subquery with semi join
3 participants