Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): To support union(all) the statement which is without from clause #1887

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix(tianmu): To support union(all) the statement which is without from clause #1887

merged 2 commits into from
Jun 26, 2023

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Jun 15, 2023

Summary about this PR

1: To fixup unsupport union or union all a sql statement which is without from clause.
2: Re-format some codes and functions.
Issue Number: close #1860

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 15, 2023
@RingsC RingsC marked this pull request as ready for review June 25, 2023 06:35
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 78.80% and project coverage change: +60.27 🎉

Comparison is base (73dcfec) 0.00% compared to head (0e9ec24) 60.27%.

❗ Current head 0e9ec24 differs from pull request most recent head 9f94496. Consider uploading reports for the commit 9f94496 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1887       +/-   ##
====================================================
+ Coverage                 0   60.27%   +60.27%     
====================================================
  Files                    0     1837     +1837     
  Lines                    0   380671   +380671     
====================================================
+ Hits                     0   229466   +229466     
- Misses                   0   151205   +151205     
Impacted Files Coverage Δ
storage/tianmu/core/just_a_table.h 100.00% <ø> (ø)
storage/tianmu/core/query_compile.cpp 65.65% <ø> (ø)
storage/tianmu/core/temp_table.h 58.33% <ø> (ø)
storage/tianmu/optimizer/compile/compiled_query.h 72.00% <ø> (ø)
storage/tianmu/sql/ha_my_tianmu.cpp 47.05% <ø> (ø)
storage/tianmu/core/engine_execute.cpp 59.38% <53.84%> (ø)
storage/tianmu/index/multi_index.h 56.66% <56.66%> (ø)
storage/tianmu/core/temp_table.cpp 74.83% <72.72%> (ø)
storage/tianmu/index/multi_index.cpp 81.45% <81.45%> (ø)
storage/tianmu/core/temp_table_com.cpp 67.85% <87.50%> (ø)
... and 5 more

... and 1822 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…m clause

1: To fixup unsupport union or union all a sql statement which is without from clause.
2: Re-format some codes and functions.
@RingsC RingsC requested a review from davidshiz June 26, 2023 12:28
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit a4600c4 into stoneatom:stonedb-5.7-dev Jun 26, 2023
6 of 7 checks passed
@RingsC RingsC deleted the fix-issue-1860-support-query-without-from-clause branch June 27, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: The query is not supported if use constant queries after union all.
4 participants