Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mtr): add order by sentence in the mtr case various_join.test #1891

Merged
merged 2 commits into from
Jun 17, 2023
Merged

test(mtr): add order by sentence in the mtr case various_join.test #1891

merged 2 commits into from
Jun 17, 2023

Conversation

Xinqiangxu
Copy link
Collaborator

@Xinqiangxu Xinqiangxu commented Jun 16, 2023 •
edited by Nliver
Loading

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@Xinqiangxu Xinqiangxu requested a review from RingsC June 16, 2023 05:54
@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-testing label Jun 16, 2023
@Xinqiangxu Xinqiangxu self-assigned this Jun 16, 2023
RingsC
RingsC approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit c990b5f into stoneatom:stonedb-5.7-dev Jun 17, 2023
6 of 7 checks passed
@Xinqiangxu Xinqiangxu deleted the fix_mtr_various_join branch July 1, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC approved these changes

@haitaoguan haitaoguan haitaoguan approved these changes

@zhongshengstoneatom zhongshengstoneatom Awaiting requested review from zhongshengstoneatom

Assignees

@Xinqiangxu Xinqiangxu

Labels
PR-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xinqiangxu @RingsC @haitaoguan