Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize: fix alert #56

Merged
merged 3 commits into from
Oct 22, 2022
Merged

Optimize: fix alert #56

merged 3 commits into from
Oct 22, 2022

Conversation

stonehank
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #56 (d3f9217) into master (8f71604) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          54       54           
  Lines        1009     1009           
  Branches      341      341           
=======================================
  Hits          986      986           
  Misses         23       23           
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/tags/hr.ts 100.00% <100.00%> (ø)
src/utils/clearComment.ts 100.00% <100.00%> (ø)
src/utils/getTagAttributes.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2022

This pull request fixes 1 alert when merging c300064 into 8f71604 - view on LGTM.com

fixed alerts:

  • 1 for Off-by-one comparison against length

@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2022

This pull request fixes 2 alerts when merging 4a42099 into 8f71604 - view on LGTM.com

fixed alerts:

  • 1 for Off-by-one comparison against length
  • 1 for DOM text reinterpreted as HTML

@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2022

This pull request fixes 4 alerts when merging d3f9217 into 8f71604 - view on LGTM.com

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Off-by-one comparison against length
  • 1 for DOM text reinterpreted as HTML

@stonehank stonehank merged commit 710e582 into master Oct 22, 2022
@stonehank stonehank deleted the feature/optimize branch October 22, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants