Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cypress to v13.6.6 #2538

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Conversation

kaylachun
Copy link
Contributor

@kaylachun kaylachun commented Mar 4, 2024

Elements Default PR Template

Upgrades cypress to latest version: v13.6.6
In general, make sure you have: (check the boxes to acknowledge you've followed this template)

Other Available PR Templates:

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit 379024b
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/65e8ca1dcaa8dc00087af1d5
😎 Deploy Preview https://deploy-preview-2538--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit 379024b
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/65e8ca1dd44bcf00089e32b0
😎 Deploy Preview https://deploy-preview-2538--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kaylachun kaylachun force-pushed the chore/upgrade-cypress-v-13 branch 2 times, most recently from b8cc3c1 to 1c0bc39 Compare March 5, 2024 16:57
return require('./cypress/plugins/index.js')(on, config);
},
baseUrl: 'http://localhost:4200/',
defaultCommandTimeout: 10000,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to increase timeout to 10s to get the angular e2e tests to pass..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's acceptable

@kaylachun kaylachun marked this pull request as ready for review March 5, 2024 23:05
@kaylachun kaylachun requested a review from a team as a code owner March 5, 2024 23:05
@kaylachun kaylachun requested a review from chohmann March 5, 2024 23:05
videosFolder: 'cypress/results/videos',
e2e: {
// We've imported your old cypress plugins here.
// You may want to clean this up later by importing these.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it here! 5e681b1

return require('./cypress/plugins/index.js')(on, config);
},
baseUrl: 'http://localhost:4200/',
defaultCommandTimeout: 10000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's acceptable

@kaylachun
Copy link
Contributor Author

@mallachari After doing some testing, it seems like upgrading testing-library/cypress caused the long test times. I'm going to only upgrade cypress to the latest version since that fixes the security issue and the tests can run within the default timeout.

@kaylachun kaylachun changed the title chore: upgrade cypress and cypress testing library chore: upgrade cypress to v13.6.6 Mar 6, 2024
@kaylachun kaylachun merged commit d002f8f into main Mar 6, 2024
7 checks passed
@kaylachun kaylachun deleted the chore/upgrade-cypress-v-13 branch March 6, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants