Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cypress to v13.6.6 #2538

Merged
merged 10 commits into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions cypress.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { defineConfig } from 'cypress';

export default defineConfig({
reporter: 'junit',
reporterOptions: {
mochaFile: 'cypress/results/output.xml',
toConsole: false,
},
screenshotsFolder: 'cypress/results/screenshots',
videosFolder: 'cypress/results/videos',
e2e: {
// We've imported your old cypress plugins here.
// You may want to clean this up later by importing these.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it here! 5e681b1

setupNodeEvents(on, config) {
return require('./cypress/plugins/index.js')(on, config);
},
baseUrl: 'http://localhost:4200/',
defaultCommandTimeout: 10000,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to increase timeout to 10s to get the angular e2e tests to pass..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's acceptable

},
});
11 changes: 0 additions & 11 deletions cypress.json

This file was deleted.

File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe('Stoplight component', () => {

cy.findByRole('button', { name: /send api request/i }).click();

cy.waitFor('@todos-api');
cy.wait('@todos-api');

cy.findByText('hello world').should('exist');
});
Expand Down Expand Up @@ -152,7 +152,7 @@ function loadMarkdownPage() {
}

function visitNode(nodeId: string, nodeSlug: string) {
cy.intercept(`https://stoplight.io/api/v1/projects/cHJqOjYwNjYx/nodes/${nodeId}`).as('getNode');
cy.intercept(`https://stoplight.io/api/v1/projects/cHJqOjYwNjYx/nodes/${nodeId}-${nodeSlug}`).as('getNode');
cy.visit(`/stoplight-project/${nodeId}-${nodeSlug}`);
cy.wait('@getNode');
}
File renamed without changes.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@
"@storybook/react": "7.5.3",
"@storybook/react-webpack5": "7.5.3",
"@storybook/theming": "7.5.3",
"@testing-library/cypress": "^7.0.3",
"@testing-library/cypress": "^10.0.1",
"@typescript-eslint/eslint-plugin": "4.28.4",
"@typescript-eslint/parser": "4.28.4",
"concurrently": "6.1.0",
"css-loader": "6.7.1",
"cssnano": "5.0.6",
"cypress": "^6.3.0",
"cypress": "^13.6.6",
"eslint": "7.31.0",
"eslint-plugin-import": "2.23.4",
"eslint-plugin-jest": "24.4.0",
Expand Down
Loading