fix: always reject invalid requests #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
fix/validate-proxy
branch
from
e50fdee
to
727ae06
Compare
XVincentX
force-pushed
the
fix/validate-proxy
branch
from
727ae06
to
fa0453a
Compare
XVincentX
force-pushed
the
fix/validate-proxy
branch
from
ee70058
to
e2ebccb
Compare
XVincentX
force-pushed
the
fix/validate-proxy
branch
from
6094a55
to
2154727
Compare
XVincentX
force-pushed
the
fix/validate-proxy
branch
from
2154727
to
6a5cd97
Compare
XVincentX
force-pushed
the
fix/validate-proxy
branch
from
6a5cd97
to
f36cce0
Compare
karol-maciaszek
suggested changes
Apr 27, 2020
| @@ -10,6 +10,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
|
|
|||
| ## Fixed | |||
|
|
|||
| - Prism will now correctly refuse invalid requests even when used with the `proxy` command [#1101](https://github.com/stoplightio/prism/pull/1101) | |||
There was a problem hiding this comment.
so long as --errors is enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a good thing and a bad thing.
The good: closes #1091, makes a better use of typings here and there and it also removes a deprecation warning
The bad: it closes the bug in a way that's not cool (basically duplicating some efforts here and there) and shows that it is probably time to resume the rethinking of the validation process that started some time ago. You can find more details on #1135