Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit accept encoding #1319

Merged
merged 2 commits into from
Jul 28, 2020
Merged

explicit accept encoding #1319

merged 2 commits into from
Jul 28, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Jul 27, 2020

Removing the compress flag will not only disable requesting compressed content but also disable the unzipping in case somebody is requesting it.

The correct solution Is to provide a default accept-encoding header so that node-fetch won't try to override it.

Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍
Screenshot 2020-07-28 at 10 31 38

@XVincentX XVincentX merged commit f5d90fa into master Jul 28, 2020
@XVincentX XVincentX deleted the fix/compress branch July 28, 2020 08:47
XVincentX added a commit that referenced this pull request Aug 24, 2020
XVincentX added a commit that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants